-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vizia Update #88
Vizia Update #88
Conversation
Thanks for the PR! A couple things that didn't work properly last time I looked at this seem to work better now, so that's great! When I merge this, I"ll end up cherry picking most of the relevant changes into my own vizia update branch I'd been working on. I'll need to redo the changes to the non-example plugins for copyright purposes (I want to keep full copyright over the GPL'd plugins so I can use bits and pieces in later projects if I want to). Some things I noticed that still need work are:
|
I pushed a change to vizia and this PR that should fix this now.
I've mentioned it before somewhere but will repeat it here for clarity, the main difference is that the old morphorm had
It is unfortunate but I have tried to address this in the PR.
Okie dokey 👍 |
I'm curious, has the patched fork diverged from Vizia such that you don't plan to merge the changes? Is there a reason not to PR the changes & depend on the original repo? |
There are no diverging changes. Every patch has been upstreamed already a long time ago. The version of Vizia |
@robbert-vdh was the |
It was merged into main 🙂 but Robbert did it himself so this one is no longer valid. |
No description provided.